fix(genai): drop format flag; extract trailing JSON #41

Merged

goldstein merged 1 commit from fix/ollama-extract-json into main 2026-04-18 12:05:47 +00:00

Conversation 0 Commits 1 Files changed 2 +50 -6

goldstein commented 2026-04-18 12:05:44 +00:00

Owner

Copy link

Reasoning models need free streaming; we just take the outermost {...}.

Reasoning models need free streaming; we just take the outermost {...}.

goldstein added 1 commit 2026-04-18 12:05:45 +00:00

fix(genai): drop Ollama format flag; extract trailing JSON from response ... 81e3b9a7d0

qwen3:14b (and deepseek-r1, other reasoning models) wrap their output
in <think>…</think> chains-of-thought before emitting real output.
With format=json the constrained sampler terminated immediately at
`{}` because the thinking block wasn't valid JSON; without format the
model thinks normally and appends the actual JSON at the end.

OllamaClient now omits the format flag and extracts the outermost
balanced `{…}` block from the response (brace depth counter, string-
literal aware). Works for reasoning models, ```json``` code-fenced
outputs, and plain JSON alike.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

goldstein merged commit 95a576f744 into main 2026-04-18 12:05:47 +00:00

goldstein referenced this pull request from a commit 2026-04-18 12:05:47 +00:00

fix(genai): extract trailing JSON (#41)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: goldstein/infoxtractor#41

No description provided.